Yet another weird program

[Nuclear Krusader]

This one compiles but hangs when the Percentil function is called.

Any suggestions?

Here is the program

TIA

[Nuclear Krusader]

Forgot to add the .dat file.

Just change the extension from txt to dat, please.

[aym]

Line 141, in function Percentil:

while (i<index);
    {
    // ...

and "i" never changes in the while loop, add "i++;" to the end of the loop.

Hehe, it took me a while to notice that semicolon

[Nuclear Krusader]

I am such a noob!!!

Thanks, aym.

[aym]

not really, it happens all the time, a couple of days ago I spent an hour or so trying to find out what was wrong with a small program I've written, after lots of looking here and there, it turned out that I used 1 / 3 which evaluates to 0, my bad, should have used 1.0 / 3.0

[Nuclear Krusader]

Aym, is there a way to make the histogram in a more efficient manner? I mean, another coding that can yield the same result without being that long?

TIA

[Jaggannath]

Don't feel like a newbie NK, the average professional programmer makes 21 errors/1000 lines, and after checking over it once this only drops to 3 errors/1000 lines

[aym]

Originally posted by Nuclear Krusader Aym, is there a way to make the histogram in a more efficient manner? I mean, another coding that can yield the same result without being that long? TIA

Yeah, I forgot to comment on this, instead of using 10 variables for pc*, perc*, and p*, you can use arrays:

pci becomes pc[ i ]
perci becomes perc[ i ]
pi becomes p[ i ]

And use for loops with these arrays, the while loop in Percentil can be re-written like this:

while (val_i < index) {
    for (i = 0; i < 10; i++) {
        if (value[val_i] >= i * 10 && value[val_i] < (i + 1) * 10 ||
            value[val_i] == 100 && i == 9) {
            perc[i]++;
            break;
        }
    }
    val_i++;
}

for  (i = 0; i < 10; i++) {
    p[i] = (float)perc[i] / (float)index;
    pc[i] = (int)perc[i] * 100;
}

Same for the rest.